PHP SQL error

[andy_jacko]

late night last night and I can barely see straight,

PHP Code:

  $updateSQL2 = sprintf("UPDATE users SET username=%s, password=%s, WHERE id=$row_Recordset1['username']", 


keep getting parse error

the error is the $row_Recordset1['username'] bit but cant remember how to corrent,

help

andy

[zinc]

missing a bracket?

$updateSQL2 = sprintf("UPDATE users SET username=%s, password=%s, WHERE id=$row_Recordset1['username']"),

Plus what's the comma doing on the end, can you post the rest of the line. If that is the end of the line then obviously you need a semi colon instead ;

[andy_jacko]

sorry the rest of the code didnt get pasted

PHP Code:

  $updateSQL2 = sprintf("UPDATE users SET username=%s, password=%s, WHERE id=$row_Recordset1['username']",
                       GetSQLValueString($_POST['username'], "text"),
                       GetSQLValueString($_POST['password'], "text")); 


[zinc]

ignore what i said then

[zinc]

Try getting rid of this comma...

password=%s,

-Ben

[andy_jacko]

still getting an error,

Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING

regards andy

[Fraser]

I think it's to do with the ' in the SQL string. You can probably get round it with backslashes or something like that but the other way would be to assign it to a variable without the ' in the name.

i.e.

PHP Code:


$id=$row_Recordset1['username'];

$updateSQL2 = sprintf("UPDATE users SET username=%s, password=%s, WHERE id=$id",
GetSQLValueString($_POST['username'], "text"),
GetSQLValueString($_POST['password'], "text")); 


[esnagel]

Try

PHP Code:

  $updateSQL2 = sprintf("UPDATE users SET username=%s, password=%s, WHERE id={$row_Recordset1['username']}",
                       GetSQLValueString($_POST['username'], "text"),
                       GetSQLValueString($_POST['password'], "text")); 


Curly braces around $row_Recordset1['username']. You didn't specify if it was a PHP error or MySQL error, but looking at the query, looks like a PHP error.

Eric

[Fraser]

When it's anything to do with PHP go with Eric's answer instead of mine

[andy_jacko]

excellent thats fixed the errors,

Im now having trouble getting the code to update 2 databases at the same time,

any ideas,

both pieces of code are similar the first updates a few more fields but i need to store usernames and passwords seperatly.


regards andy